-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aci): use feature check for aci #1508
Conversation
a1a059d
to
7fa68c5
Compare
7fa68c5
to
f4f9202
Compare
src/lib/Preview.js
Outdated
...this.previewOptions, | ||
features: { ...this.previewOptions.features, advancedContentInsights: options }, | ||
}; | ||
this.viewer.pageTracker.updateOptions(this.previewOptions.features.advancedContentInsights); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just use options
as the argument to the function here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain why we should do so ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: I also found it a bit difficult to grasp having both options
and this.options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I still find this confusing as well. Why not just call this.viewer.pageTracker.updateOptions(newOptions)
here? It's much easier to read in my option and stays more consistent with the rest of this code block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's benefit of these changes if we already have a configuration object for these options? We appear to be increasing complexity at every layer.
It was one of PMAI's and intention behind this change was to stick to "feature checking" mechanism implemented for Preview and to hide rest of ACI codebase under the feature flip. |
@ahorowitz123 @jstoffan thanks for your comments. I updated this PR |
b8504cd
to
3e389f5
Compare
This pr introduces changes to cover ACI codebase with feature checking