Move documentation into viewer folders #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tonyjin
commented
Mar 22, 2017
tonyjin
commented
- Move viewer documentation into their respective src folders
- Rename to README.md so they show up in Github
- Consolidate documentation for folders with multiple viewers
- Move viewer documentation into their respective src folders - Rename to README.md so they show up in Github - Consolidate documentation for folders with multiple viewers
This was referenced Jun 6, 2017
Closed
mxiao6
added a commit
to mxiao6/box-content-preview
that referenced
this pull request
Jul 17, 2018
* New: Add fake excel viewer and add it to docLoader * New: Finish the dummy-viewer * New: Can parse using sheetjs on the client * New: SheetJS prototype * New: Parse xlsx in the viewer * Fix: Eslint * New: Remove XLSX package * Fix: Remove lodash and fix following issues * Fix: Grids text overlap * Fix: install modules from public instead of jfrog * Fix: use meaningful filename
mxiao6
added a commit
to mxiao6/box-content-preview
that referenced
this pull request
Jul 17, 2018
* New: Add fake excel viewer and add it to docLoader * New: Finish the dummy-viewer * New: Can parse using sheetjs on the client * New: SheetJS prototype * New: Parse xlsx in the viewer * Fix: Eslint * New: Remove XLSX package * Fix: Remove lodash and fix following issues * Fix: Grids text overlap * Fix: install modules from public instead of jfrog * Fix: use meaningful filename
ConradJChan
pushed a commit
to ConradJChan/box-content-preview
that referenced
this pull request
Sep 16, 2019
mergify bot
pushed a commit
that referenced
this pull request
Sep 17, 2019
* chore(dashviewer): video playback performance instrumentation * chore(dashviewer): emit metric on beforeunload event * chore: adding missing jsdoc * chore: moved loadUI around and fixed unit tests * chore: addressing PR comments * chore: moving loadUI in DashViewer back * chore: adding new unit test coverage * chore: fix CI unit test issue * chore: attempt to fix CI test issue #2 * chore: attempt #3 to fix unit tests * chore: add mediaEl check in processMetrics * chore: addressing a few more PR comments * chore: removing seeked from quickSeek * chore: more PR comments
benjamin-shen
pushed a commit
to benjamin-shen/box-content-preview
that referenced
this pull request
Jun 28, 2022
Edit image icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.