fix(content-uploader): fix multiple items droppable issue #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-in-a-box
approved these changes
Jun 17, 2024
shahzadaziz
approved these changes
Jun 17, 2024
mhagmajer
pushed a commit
to mhagmajer/box-ui-elements
that referenced
this pull request
Jul 4, 2024
* fix(content-uploader): fix multiple items droppable issue * fix(content-uploader): add tests * fix(content-uploader): fix flow issue
tjuanitas
reviewed
Jul 10, 2024
| @@ -426,20 +424,20 @@ class ContentUploader extends Component<Props, State> { | |||
| * @private | |||
| * @param {Array<DataTransferItem | UploadDataTransferItemWithAPIOptions>} dataTransferItems | |||
| * @param {Function} itemUpdateCallback | |||
| * @returns {void} | |||
| * @returns {Promise<any>} | |||
There was a problem hiding this comment.
this should stay void? since there's no return statement happening nvm async functions returns a promise
https://stackoverflow.com/questions/43422932/async-await-always-returns-promise
mergify bot
added a commit
that referenced
this pull request
Jul 18, 2024
* fix(content-uploader): fix multiple items droppable issue (#3565) * fix(content-uploader): fix multiple items droppable issue * fix(content-uploader): add tests * fix(content-uploader): fix flow issue * feat: support metadata suggestions API * feat: check generated files * fix: remove only * fix: tests * fix: req comments --------- Co-authored-by: Jerry Jiang <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
kajarosz
pushed a commit
to kajarosz/box-ui-elements
that referenced
this pull request
Aug 21, 2024
* fix(content-uploader): fix multiple items droppable issue * fix(content-uploader): add tests * fix(content-uploader): fix flow issue
kajarosz
pushed a commit
to kajarosz/box-ui-elements
that referenced
this pull request
Aug 21, 2024
* fix(content-uploader): fix multiple items droppable issue (box#3565) * fix(content-uploader): fix multiple items droppable issue * fix(content-uploader): add tests * fix(content-uploader): fix flow issue * feat: support metadata suggestions API * feat: check generated files * fix: remove only * fix: tests * fix: req comments --------- Co-authored-by: Jerry Jiang <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.