Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacto delete screenshot #856

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Commits on Aug 18, 2022

  1. Configuration menu
    Copy the full SHA
    54054c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Configuration menu
    Copy the full SHA
    55eb565 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4eab6f4 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. So in the PR, basically turned the data source singleton into a class…

    … that can be parametrized given Actions callback
    
    This way each modal can have its own independent callback (and we don't broadcast).
    
    See how register Async is moved into the childrens.
    
    General thinking, we had:
    S1(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A.onDeleteSuccess --> S1.onDeleteSuccess
                                                                               --> S2.onDeleteSuccess
    S2(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A.onDeleteSuccess --> S1.onDeleteSuccess
                                                                               --> S2.onDeleteSuccess
    
    we want:
    
    S1(DS1) -> onDelete() --> DS1.delete --> DS1.success --> A1.onDeleteSuccess --> S1.onDeleteSuccess
    S2(DS2) -> onDelete() --> DS2.delete --> DS2.success --> A2.onDeleteSuccess --> S2.onDeleteSuccess
    
    --> DS1 must be replaced from singleton to parametrized class with action
    aurambaj committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    89a6ef4 View commit details
    Browse the repository at this point in the history