Not able to build on Mac M1 because Cannot download node - 404 | Slack notification not working because using a depreciated api endpoint #883
Conversation
…t building on M1 machine
…e from 1.10.0 to 1.11.0 to support building on M1 machine
|
kdcyberdude seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
kdcyberdude
changed the title
|
@kdcyberdude can you accept the license/cla, so i can merge your changes? |
| @@ -25,7 +25,7 @@ public class SlackClient { | |||
|
|
|||
| static final String BASE_API_URL = "https://slack.com/api/"; | |||
| static final String API_USER_LOOKUP_BY_EMAIL = "users.lookupByEmail"; | |||
| static final String API_IM_OPEN = "im.open"; | |||
| static final String API_IM_OPEN = "conversation.open"; | |||
There was a problem hiding this comment.
would you mind renaming the constant?
Does the new entry point take the exact same input, I check the doc quickly and it seems to now use "users" field in the payload and not "user"? Have you tried it with that exact code?
There was a problem hiding this comment.
revisiting this, it needs converstation"s" and also change the payload, coming up with another PR for this
There was a problem hiding this comment.
Hi @aurambaj, I've already signed a CLA agreement months ago but it's still pending with the following reason.
kdcyberdude seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
I suggest you to push the changes yourself. As you mentioned it is needs "conversations" in the API and "users" in the parameters. I had made the changes month ago and tested it already.
One more thing, can you update the docs mentioning the slack notification trigger points. Still I am not able to fully understand when the notification get's triggered if multiple developers are pushing the changes in their respective branch on mojito.
There was a problem hiding this comment.
🤔 that's unfortunate, not sure what's happening. I went ahead and commit: 4d205e4 for the slack client fix.
Thanks for following up!
The way we use it is that each developer as it own feature branch. they are independent branches (with their own new/deleted strings) so each developer have their own notifications as described in that doc: https://www.mojito.global//docs/guides/branching/. The string set in Mojito is the union of the string on all branches. Do you use it the same way? What's unclear? are you missing notifications?
|
could not merge at the time CLA, but the content of this PR was eventually added |
Why the project is not building on Mac M1 - eirslett/frontend-maven-plugin#952 (comment)
Why slack notification is not working - howdyai/botkit#1988