test(trajectory_follower_nodes): delete flaky set_param_smoke_test (t…

…ier4#1103) Signed-off-by: Maxime CLEMENT <[email protected]>
boyali · Oct 3, 2022 · 57b1acf · 57b1acf
1 parent 76f190d
commit 57b1acf
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 26 deletions.
diff --git a/control/trajectory_follower_nodes/test/test_lateral_controller_node.cpp b/control/trajectory_follower_nodes/test/test_lateral_controller_node.cpp
@@ -433,16 +433,3 @@ TEST_F(FakeNodeFixture, stopped)
   EXPECT_EQ(cmd_msg->steering_tire_rotation_rate, 0.0f);
   EXPECT_GT(rclcpp::Time(cmd_msg->stamp), rclcpp::Time(traj_msg.header.stamp));
 }
-
-// TODO(Maxime CLEMENT): disabled as this test crashes in the CI but works locally
-TEST_F(FakeNodeFixture, DISABLED_set_lateral_param_smoke_test)
-{
-  // Node
-  std::shared_ptr<LateralController> node = makeLateralNode();
-  // give the node some time to initialize completely
-  std::this_thread::sleep_for(std::chrono::milliseconds{100LL});
-
-  // Change some parameter value
-  auto result = node->set_parameter(rclcpp::Parameter("mpc_prediction_horizon", 10));
-  EXPECT_TRUE(result.successful);
-}
diff --git a/control/trajectory_follower_nodes/test/test_longitudinal_controller_node.cpp b/control/trajectory_follower_nodes/test/test_longitudinal_controller_node.cpp
@@ -469,16 +469,3 @@ TEST_F(FakeNodeFixture, longitudinal_emergency)
   EXPECT_DOUBLE_EQ(cmd_msg->speed, 0.0f);
   EXPECT_LT(cmd_msg->acceleration, 0.0f);
 }
-
-TEST_F(FakeNodeFixture, longitudinal_set_param_smoke_test)
-{
-  // Node
-  std::shared_ptr<LongitudinalController> node = makeLongitudinalNode();
-
-  // give the node some time to initialize completely
-  std::this_thread::sleep_for(std::chrono::milliseconds{100LL});
-
-  // Change some parameter value
-  auto result = node->set_parameter(rclcpp::Parameter("kp", 1.0));
-  EXPECT_TRUE(result.successful);
-}