Added ReasonML support #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyter
reviewed
Sep 20, 2020
languages.json
Outdated
| } | ||
| ], | ||
| "shebangs": [ | ||
| "node" |
There was a problem hiding this comment.
Need to remove this :)
It will conflict with the existing one. Not sure if there is some specific shebang for reason.
|
Only issue I can see is the shebang. It will conflict with the existing Javascript ones, which is probably not what we want. Is there some specific shebang for reason? Otherwise it looks good! |
|
Just pushed it without |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reasonml.github.io/
Mostly copied the JavaScript implementation because it's comparable.
I wasn't sure about
shebangsand couldn't find immediately what that should be set as.Let me know if I should change something :)