Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for krew index #152

Merged
merged 8 commits into from
Dec 27, 2023
Merged

fixes for krew index #152

merged 8 commits into from
Dec 27, 2023

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Dec 27, 2023

fixes after kubernetes-sigs/krew-index#3557
how to test krew-index manually?

@Slach Slach changed the title fixes after https://github.com/kubernetes-sigs/krew-index/pull/3557 fixes for krew index Dec 27, 2023
@Slach
Copy link
Contributor Author

Slach commented Dec 27, 2023

tested manually with

docker run --rm -v ./.krew/tail.yaml:/tmp/template-file.yaml ghcr.io/rajatjindal/krew-release-bot:v0.0.46 krew-release-bot template --tag v0.17.2 --template-file /tmp/template-file.yaml 1>/tmp/tail.yaml

go install sigs.k8s.io/krew/cmd/validate-krew-manifest@latest

~/go/bin/validate-krew-manifest -manifest /tmp/tail.yaml  

@Slach
Copy link
Contributor Author

Slach commented Dec 27, 2023

I1227 12:46:06.785272   16076 main.go:68] reading file "tail.yaml"
I1227 12:46:06.812776   16076 main.go:85] structural validation OK
I1227 12:46:06.812776   16076 main.go:93] all spec.platform[] items are used
I1227 12:46:06.813776   16076 main.go:99] no overlapping spec.platform[].selector
I1227 12:46:06.823773   16076 main.go:104] installing spec.platform[0]
I1227 12:46:51.870289   16076 main.go:108] installed  spec.platforms[0]
I1227 12:46:51.870289   16076 main.go:104] installing spec.platform[1]
I1227 12:47:49.241802   16076 main.go:108] installed  spec.platforms[1]
I1227 12:47:49.244240   16076 main.go:104] installing spec.platform[2]
I1227 12:48:07.778364   16076 main.go:108] installed  spec.platforms[2]
I1227 12:48:07.778364   16076 main.go:104] installing spec.platform[3]
I1227 12:48:32.151093   16076 main.go:108] installed  spec.platforms[3]
I1227 12:48:32.151093   16076 main.go:104] installing spec.platform[4]
I1227 12:49:30.511562   16076 main.go:108] installed  spec.platforms[4]
I1227 12:49:30.511562   16076 main.go:104] installing spec.platform[5]
I1227 12:50:28.876685   16076 main.go:108] installed  spec.platforms[5]
2023/12/27 12:50:28 all 6 spec.platforms installed fine  

please merge it, release 0.17.3 and create PR in krew-index

@Slach
Copy link
Contributor Author

Slach commented Dec 27, 2023

@mnaser please look, merge and tag new release

@mnaser mnaser merged commit 419f57a into boz:master Dec 27, 2023
1 check passed
@mnaser
Copy link
Collaborator

mnaser commented Dec 27, 2023

thank you @Slach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants