Fix object size being 0 when retrying request (#14) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the code only put the hash in the cache and not the size, the size that was sent in a retried request was 0. Some server implementations check the size, so those requests may fail. To fix it, also put the size in the cache and use it when creating a request from the cache.
| @@ -60,7 +60,7 @@ public GitConverter(@NotNull File cachePath, @NotNull File basePath, @NotNull St | |||
| .mmapFileEnable() | |||
| .cacheSoftRefEnable() | |||
| .make(); | |||
| cacheSha256 = cache.getHashMap("sha256"); | |||
| cacheMeta = cache.getHashMap("meta"); | |||
There was a problem hiding this comment.
Changed the name so that it works for old cache files too.
|
It's really good change. Thanks a lot 👍 |
|
Sorry for delay. I was offline for two weeks. |
|
No worries, thanks! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the code only put the hash in the cache and not the size, the
size that was sent in a retried request was 0.
Some server implementations check the size, so those requests may fail.
To fix it, also put the size in the cache and use it when creating a
request from the cache.