Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure existing values are preserved #86

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Ensure existing values are preserved #86

merged 3 commits into from
Apr 19, 2024

Commits on Apr 19, 2024

  1. fix(cloud-element-templates): always apply conditional template 

    fix(cloud-element-templates): only apply conditional portion of template

* ensures we properly account for default values
* when we apply a conditional template, ensure we test conditions
  against the original template

----

Documented in https://github.com/bpmn-io/element-templates/blob/main/docs/LIFE_CYCLE.md#upgrade-behavior

Related to camunda/camunda-modeler#4249
    @nikku
    nikku committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    722352f View commit details
    Browse the repository at this point in the history

  2. chore(cloud-element-templates): drop unnecessary check 

    We apply conditional logic independent of whether old and new template
are the same; any change (upgrade) may trigger it, the only important
aspect to consider is if actual bindings changed (and hence we need
to reapply.
    @nikku
    nikku committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    1a88278 View commit details
    Browse the repository at this point in the history

  3. test(cloud-element-templates): simplify conditional test case 

    Do not depend element transformation for dependent dropdowns test.
    @nikku
    nikku committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    576aa00 View commit details
    Browse the repository at this point in the history