Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-overlapping-elements Rule Produces Error When Using Collapsed Subprocess With Data Object Reference #133

Closed
philippfromme opened this issue May 9, 2024 · 1 comment · Fixed by #136
Assignees
Labels
bug Something isn't working good first issue Good for newcomers rules Concerning existing or missing rules spring cleaning Could be cleaned up one day

Comments

@philippfromme
Copy link
Contributor

Describe the Bug

Modeling the following diagram will result in an error produced by the no-overlapping-elements rule.

<?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:modeler="http://camunda.org/schema/modeler/1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:camunda="http://camunda.org/schema/1.0/bpmn" id="Definitions_1" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Web Modeler" exporterVersion="2e3ddd0" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="8.5.0" camunda:diagramRelationId="203800ac-7cd5-41a9-9ca9-e7bebf6db476">
<bpmn:process id="Process_1" isExecutable="true">
  <bpmn:subProcess id="Subprocess_1">
    <bpmn:dataObjectReference id="DataObjectReference_1" dataObjectRef="DataObject_03l91qi" />
    <bpmn:dataObject id="DataObject_03l91qi" />
  </bpmn:subProcess>
</bpmn:process>
<bpmndi:BPMNDiagram id="BPMNDiagram_1">
  <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="Process_1">
    <bpmndi:BPMNShape id="Activity_0f2q80d_di" bpmnElement="Subprocess_1">
      <dc:Bounds x="160" y="78" width="100" height="80" />
      <bpmndi:BPMNLabel />
    </bpmndi:BPMNShape>
  </bpmndi:BPMNPlane>
</bpmndi:BPMNDiagram>
<bpmndi:BPMNDiagram id="BPMNDiagram_06lehem">
  <bpmndi:BPMNPlane id="BPMNPlane_0dasf4f" bpmnElement="Subprocess_1">
    <bpmndi:BPMNShape id="DataObjectReference_0r9j7hc_di" bpmnElement="DataObjectReference_1">
      <dc:Bounds x="152" y="85" width="36" height="50" />
    </bpmndi:BPMNShape>
  </bpmndi:BPMNPlane>
</bpmndi:BPMNDiagram>
</bpmn:definitions>

The error:

rule <no-overlapping-elements> failed with error:  TypeError: Cannot read properties of undefined (reading 'bounds')
    at no-overlapping-elements.js:70:47

Steps to Reproduce

  1. Lint the given process
  2. no-overlapping-elements rule produces error

Expected Behavior

No error.

Environment

  • Library version: 10.2.1
@philippfromme philippfromme added the bug Something isn't working label May 9, 2024
@barmac
Copy link
Member

barmac commented May 9, 2024

I can reproduce this.

@barmac barmac added good first issue Good for newcomers backlog Queued in backlog spring cleaning Could be cleaned up one day rules Concerning existing or missing rules labels May 9, 2024
@nikku nikku self-assigned this May 28, 2024
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels May 28, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels May 29, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers rules Concerning existing or missing rules spring cleaning Could be cleaned up one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants