Fix compilation on Windows #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmn-io-tasks
bot
added
needs review
|
This fixes compilation of custom configs on 🪟. @philippfromme if you want to you could add a unit test along the lines of #113. |
|
Verified to work for |
|
One of the issues I fixed on my branch is that the paths are absolute: I'm not sure if this is only happening on Windows. |
|
This now also make sure rules are imported from modules instead of absolute paths. |
|
@nikku I've added my changes. Please have a look. |
|
I've cleaned up the commits. One final remark we could consider: https://github.com/bpmn-io/bpmnlint/pull/114/files#r1270570682. |
nikku
commented
Jul 21, 2023
philippfromme
force-pushed
the
test-compile
branch
from
2fc7951
to
e088a87
Compare
nikku
commented
Jul 21, 2023
nikku
force-pushed
the
test-compile
branch
2 times, most recently
from
abe4038
to
bfd24f1
Compare
+ remove unnecessary cache action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #112, which turned out to be a 🪟 only issue.
As it stands we need to properly convert paths between 🪟 and 🐧 before we normalize or join, as these node utilities do a bad (to no) job of converting.