Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Version tag field #97

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Add Version tag field #97

merged 1 commit into from
Aug 26, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jul 11, 2024 •
edited
Loading

Proposed Changes

  • adds Version tag field to decisions

image

Related to camunda/camunda-modeler#4454

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Jul 11, 2024
@philippfromme philippfromme force-pushed the version-tag branch 2 times, most recently from 236753f to c4b2ba8 Compare July 11, 2024 13:15
@philippfromme philippfromme added the ready Ready to be worked on label Jul 23, 2024 — with bpmn-io-tasks
@philippfromme philippfromme removed the in progress Currently worked on label Jul 23, 2024
@philippfromme philippfromme marked this pull request as ready for review August 23, 2024 13:16
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed ready Ready to be worked on labels Aug 23, 2024
nikku
nikku approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine. Well structured + tested.

@nikku
Copy link
Member

nikku commented Aug 26, 2024

Meta-comment:

  • As we add many different things it would have been easier to add the infrastructure (tooltips), ... in separate PRs.

@nikku nikku merged commit dbb2291 into main Aug 26, 2024
7 of 8 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Aug 26, 2024
@nikku nikku deleted the version-tag branch August 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@marstamm marstamm Awaiting requested review from marstamm

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku