test: use waitFor for editor variables test

bpmn-io · May 24, 2024 · 5f97076 · 5f97076
1 parent 8d4051c
commit 5f97076
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/dmn-js-literal-expression/package.json b/packages/dmn-js-literal-expression/package.json
@@ -26,6 +26,7 @@
     "literal expression"
   ],
   "devDependencies": {
+    "@testing-library/dom": "^10.1.0",
     "dmn-font": "^0.6.2",
     "inferno-test-utils": "~5.6.2"
   },

diff --git a/packages/dmn-js-literal-expression/test/spec/features/textarea/TextareaEditorSpec.js b/packages/dmn-js-literal-expression/test/spec/features/textarea/TextareaEditorSpec.js
@@ -12,6 +12,8 @@ import { triggerInputEvent } from 'dmn-js-shared/test/util/EventUtil';
 
 import TestContainer from 'mocha-test-container-support';
 
+import { waitFor } from '@testing-library/dom';
+
 import literalExpressionXML from '../../literal-expression.dmn';
 
 import CoreModule from 'src/core';
@@ -98,7 +100,7 @@ describe('textarea editor', function() {
       await changeInput(document.activeElement, 'Var');
 
       // then
-      return expectEventually(() => {
+      return waitFor(() => {
         const options = testContainer.querySelectorAll('[role="option"]');
 
         expect(options).to.exist;
@@ -135,16 +137,3 @@ async function act(fn) {
     });
   });
 }
-
-async function expectEventually(fn) {
-  for (let i = 0; i < 20; i++) {
-    try {
-      await fn();
-      return;
-    } catch {
-      await act(() => {});
-    }
-  }
-
-  await fn();
-}