Implement variable suggestions #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
marstamm and
smbea
and removed request for
a team
barmac
force-pushed
the
785-variable-suggestions
branch
from
861fff9
to
6cda9a3
Compare
bpmn-io-tasks
bot
added
needs review
|
Works great, love the feature! Have you considered adding an integration test for the feature? |
What would it test? |
|
I was thinking that we could check that variables are passed to the Editor component, if that is manageable. If not, feel free to merge anyway |
barmac
force-pushed
the
785-variable-suggestions
branch
from
5382c57
to
1b2efbf
Compare
marstamm
approved these changes
Oct 12, 2023
|
Amazing stuff! 🎉 |
|
Let's ship it ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2023-10-06.at.15.35.15.mov
Closes #785