Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snippet suggestions for BKM #872

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

barmac
Copy link
Member

@barmac barmac commented May 27, 2024

Screen.Recording.2024-05-27.at.09.40.19.mov

Closes #785
Closes #827

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 27, 2024
@barmac barmac requested review from a team, philippfromme, marstamm and nikku and removed request for a team May 27, 2024 07:44
@barmac barmac force-pushed the 827-snippet-suggestion-bkm branch from 6ac2999 to 96d2032 Compare May 27, 2024 08:52
@barmac barmac force-pushed the 827-snippet-suggestion-bkm branch from 96d2032 to 56905c8 Compare May 27, 2024 11:20
@nikku
Copy link
Member

nikku commented May 27, 2024

Works great.

Stumbled again over #838, which should be a simple follow-up fix #838 (comment).

Stumbled over an UX issue: #875.

@barmac
Copy link
Member Author

barmac commented May 27, 2024

Makes sense, thanks for the review and reporting.

@barmac barmac merged commit cdb3c41 into develop May 27, 2024
8 checks passed
@barmac barmac deleted the 827-snippet-suggestion-bkm branch May 27, 2024 11:57
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display BKM in autosuggestions Implement variable suggestions
2 participants