[CLOSED] LSP Find References Feature

[core-ai-bot]

Issue by niteskum
Wednesday Apr 10, 2019 at 13:14 GMT
Originally opened as adobe/brackets#14693

---

---

niteskum included the following code: https://github.com/adobe/brackets/pull/14693/commits

[core-ai-bot]

Comment by niteskum
Wednesday Apr 10, 2019 at 13:46 GMT

---

@shubhsnov @swmitra Please review
@narayani28

[core-ai-bot]

Comment by shubhsnov
Thursday Apr 11, 2019 at 07:29 GMT

---

@niteskum I've still got to check the functional aspects, but I've given a few code nits that I came across on first glance.

Could you also please add a proper description for the PR along with the UI aspects.

[core-ai-bot]

Comment by niteskum
Thursday Apr 11, 2019 at 07:30 GMT

---

Small Modifications in SerachResultsView class to show references results.

Find References UI:

On Right Click:

References Results UI:

[core-ai-bot]

Comment by shubhsnov
Friday Apr 12, 2019 at 18:26 GMT

---

@niteskum The string should get highlighted as in search results. Is there any particular reason for why this is not happening?

[core-ai-bot]

Comment by niteskum
Friday Apr 12, 2019 at 20:29 GMT

---

@niteskum The string should get highlighted as in search results. Is there any particular reason for why this is not happening?

@shubhsnov fixed it.

[core-ai-bot]

Comment by shubhsnov
Saturday Apr 13, 2019 at 02:35 GMT

---

Apart from a few refactoring changes, this looks good to me.

[core-ai-bot]

Comment by niteskum
Sunday Apr 14, 2019 at 15:10 GMT

---

Apart from a few refactoring changes, this looks good to me.

@shubhsnov Addressed all review comments.
for "Find All References" I am using "Ctrl-Shift-K" shortcut as "Ctrl-Shift-R" is already used for reloadLivePreview.

[core-ai-bot]

Comment by narayani28
Monday Apr 15, 2019 at 04:27 GMT

---

ctrl+k is used for quick docs and ctrl+shift+k is not very intuitive. is there any non used ctrl+ available for usage?

[core-ai-bot]

Comment by shubhsnov
Monday Apr 15, 2019 at 06:06 GMT

---

LGTM 👍