LSP Find References Feature #14693

niteskum · 2019-04-10T13:14:35Z

No description provided.

niteskum · 2019-04-10T13:46:22Z

@shubhsnov @swmitra Please review
@narayani28

shubhsnov · 2019-04-10T15:34:54Z

src/features/FindReferencesManager.js

@@ -0,0 +1,151 @@
+/*
+ * Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.


shubhsnov · 2019-04-10T15:36:40Z

src/features/FindReferencesManager.js

+
+        var model = searchModel;
+        _resultsView = new SearchResultsView(
+            model,


Directly use searchModel here.

shubhsnov · 2019-04-10T15:38:13Z

src/features/FindReferencesManager.js

+        ),
+        removeFindReferencesProvider = _providerRegistrationHandler.removeProvider.bind(_providerRegistrationHandler);
+
+    var SHOW_FIND_REFERENCES_CMD_ID   = "showrReferences",


Nit: Typo "showReferences"

shubhsnov · 2019-04-10T15:39:54Z

src/features/FindReferencesManager.js

+                searchModel.numMatches = rcvdObj.numMatches;
+                searchModel.allResultsAvailable = true;
+                searchModel.setQueryInfo({query: rcvdObj.queryInfo, caseSensitive: true, isRegExp: false});
+                //searchModel.fireChanged();


Remove commented code.

shubhsnov · 2019-04-10T15:40:40Z

src/features/FindReferencesManager.js

+    }
+
+    function _openReferencesPanel() {
+


Remove empty line.

shubhsnov · 2019-04-10T15:42:29Z

src/features/FindReferencesManager.js

+        referencespromise = _getReferences(referencesProvider, editor, pos);
+
+        // Use default error message if none other provided
+        errorMsg = errorMsg || defaultErrorMsg;


Where are errorMsg and defaultErrorMsg being set?

src/languageTools/DefaultProviders.js

shubhsnov · 2019-04-10T15:45:55Z

src/languageTools/DefaultProviders.js

+    };
+
+    ReferencesProvider.prototype.getReferences = function() {
+        var editor = EditorManager.getActiveEditor(),


Why aren't you using the hostEditor and pos that is being passed by manager?

shubhsnov · 2019-04-10T15:48:57Z

src/search/SearchResultsView.js

@@ -72,14 +72,16 @@ define(function (require, exports, module) {
     * @param {SearchModel} model The model that this view is showing.
     * @param {string} panelID The CSS ID to use for the panel.
     * @param {string} panelName The name to use for the panel, as passed to WorkspaceManager.createBottomPanel().
+     * @param {string} type type to indentify if it is reference search or string match serach


Typo: identify

You still need to fix this.

src/search/SearchResultsView.js

shubhsnov · 2019-04-11T07:29:44Z

@niteskum I've still got to check the functional aspects, but I've given a few code nits that I came across on first glance.

Could you also please add a proper description for the PR along with the UI aspects.

niteskum · 2019-04-11T07:30:53Z

Small Modifications in SerachResultsView class to show references results.

Find References UI:

On Right Click:

References Results UI:

…thub.com/niteskum/brackets into lspFindReferences

shubhsnov · 2019-04-12T18:26:26Z

@niteskum The string should get highlighted as in search results. Is there any particular reason for why this is not happening?

niteskum · 2019-04-12T20:29:01Z

@niteskum The string should get highlighted as in search results. Is there any particular reason for why this is not happening?

@shubhsnov fixed it.

src/features/keyboard.json

shubhsnov · 2019-04-13T02:08:30Z

src/search/SearchResultsView.js

@@ -72,14 +72,16 @@ define(function (require, exports, module) {
     * @param {SearchModel} model The model that this view is showing.
     * @param {string} panelID The CSS ID to use for the panel.
     * @param {string} panelName The name to use for the panel, as passed to WorkspaceManager.createBottomPanel().
+     * @param {string} type type to indentify if it is reference search or string match serach


You still need to fix this.

src/features/FindReferencesManager.js

src/features/keyboard.json

src/languageTools/DefaultProviders.js

shubhsnov · 2019-04-13T02:35:42Z

Apart from a few refactoring changes, this looks good to me.

niteskum · 2019-04-14T15:10:29Z

Apart from a few refactoring changes, this looks good to me.

@shubhsnov Addressed all review comments.
for "Find All References" I am using "Ctrl-Shift-K" shortcut as "Ctrl-Shift-R" is already used for reloadLivePreview.

src/languageTools/DefaultProviders.js

src/features/FindReferencesManager.js

src/extensions/default/PhpTooling/main.js

…ndReferences

narayani28 · 2019-04-15T04:27:53Z

ctrl+k is used for quick docs and ctrl+shift+k is not very intuitive. is there any non used ctrl+ available for usage?

shubhsnov · 2019-04-15T06:06:59Z

LGTM 👍

LSP Find References Feature

641f9dd

niteskum changed the title ~~LSP Find References Feature~~ LSP Find References Feature < work in Progress> Apr 10, 2019

Addressed bugs

d8b9a1a

shubhsnov reviewed Apr 11, 2019

View reviewed changes

niteskum and others added 4 commits April 11, 2019 14:07

Addressed review comments

149c705

Addressed review comments

84e791f

Changes to send data only once per 24 hours

f07c8e7

Adding Unit Test cases and supporting files

8f1cc7f

niteskum changed the title ~~LSP Find References Feature < work in Progress>~~ LSP Find References Feature Apr 11, 2019

niteskum added 2 commits April 11, 2019 21:00

Merge branch 'snchit_fix_for_send_event_every_24_hours' of https://gi…

4ee75fa

…thub.com/niteskum/brackets into lspFindReferences

changed string

d50b154

niteskum added 2 commits April 13, 2019 01:42

fixed review comments

4eb0627

Addressed review comments

5cacecd

shubhsnov reviewed Apr 13, 2019

View reviewed changes

Addressed review comments

226c13b

shubhsnov reviewed Apr 14, 2019

View reviewed changes

src/languageTools/DefaultProviders.js Outdated Show resolved Hide resolved

src/features/FindReferencesManager.js Show resolved Hide resolved

src/features/FindReferencesManager.js Outdated Show resolved Hide resolved

src/extensions/default/PhpTooling/main.js Show resolved Hide resolved

Merge branch 'master' of https://github.com/adobe/brackets into lspFi…

7bcdb59

…ndReferences

niteskum added 2 commits April 15, 2019 15:47

Changed Shortcut to Ctrl-M

6980edf

Changed the Shortcut to Shift-F12

5e041df

shubhsnov merged commit 317992f into adobe:master Apr 15, 2019

core-ai-bot mentioned this pull request Aug 30, 2021

[CLOSED] LSP Find References Feature brackets-archive/bracketsIssues#11984

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LSP Find References Feature #14693

LSP Find References Feature #14693

niteskum commented Apr 10, 2019

niteskum commented Apr 10, 2019 •

edited

Loading

shubhsnov Apr 10, 2019

shubhsnov Apr 10, 2019

shubhsnov Apr 10, 2019

shubhsnov Apr 10, 2019

shubhsnov Apr 10, 2019

shubhsnov Apr 10, 2019

shubhsnov Apr 10, 2019

shubhsnov Apr 10, 2019

shubhsnov Apr 13, 2019

shubhsnov commented Apr 11, 2019 •

edited

Loading

niteskum commented Apr 11, 2019 •

edited

Loading

shubhsnov commented Apr 12, 2019

niteskum commented Apr 12, 2019 •

edited

Loading

shubhsnov Apr 13, 2019

shubhsnov commented Apr 13, 2019 •

edited

Loading

niteskum commented Apr 14, 2019

narayani28 commented Apr 15, 2019

shubhsnov commented Apr 15, 2019

		@@ -0,0 +1,151 @@
		/*
		* Copyright (c) 2013 - present Adobe Systems Incorporated. All rights reserved.

LSP Find References Feature #14693

LSP Find References Feature #14693

Conversation

niteskum commented Apr 10, 2019

niteskum commented Apr 10, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shubhsnov commented Apr 11, 2019 • edited Loading

niteskum commented Apr 11, 2019 • edited Loading

shubhsnov commented Apr 12, 2019

niteskum commented Apr 12, 2019 • edited Loading

Choose a reason for hiding this comment

shubhsnov commented Apr 13, 2019 • edited Loading

niteskum commented Apr 14, 2019

narayani28 commented Apr 15, 2019

shubhsnov commented Apr 15, 2019

niteskum commented Apr 10, 2019 •

edited

Loading

shubhsnov commented Apr 11, 2019 •

edited

Loading

niteskum commented Apr 11, 2019 •

edited

Loading

niteskum commented Apr 12, 2019 •

edited

Loading

shubhsnov commented Apr 13, 2019 •

edited

Loading