Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix highlighting 10325 #13095

Open
core-ai-bot opened this issue Aug 31, 2021 · 5 comments
Open

Fix highlighting 10325 #13095

core-ai-bot opened this issue Aug 31, 2021 · 5 comments

Comments

@core-ai-bot
Copy link
Member

Issue by aringot
Friday Mar 13, 2015 at 01:04 GMT
Originally opened as adobe/brackets#10737


Fix for: adobe/brackets#10325
Also discussed here : https://groups.google.com/forum/#!topic/brackets-dev/SPokrvCyh9Y

The goal of my fix is to add (actually keep) a highlight on the (now) inactive-pane focused line when you use several panes and have the "Highlight Active Line" option checked.

Here is how it looks like with the light theme :
image

With the dark theme :
image

Only the currently focused line has a line number colored differently to clearly see the difference between active and inactive pane. (and the highlight is a bit dimmer for the inactive pane)

As it is just about styles, I didn't modify any JavaScript, I only modified LESS files.
I tested that the modification was effective both on light and dark theme, for normal and inline editors.


aringot included the following code: https://github.com/adobe/brackets/pull/10737/commits

@core-ai-bot
Copy link
Member Author

Comment by abose
Wednesday Mar 25, 2015 at 09:05 GMT


@aringot I coudnt get this to work. I just fetched the pull request and reloaded brackets, but the active line hilights are not coming. should i do something more to get this to work?

@core-ai-bot
Copy link
Member Author

Comment by prksingh
Thursday Apr 02, 2015 at 10:28 GMT


@abose View > Highlight Active Line

@core-ai-bot
Copy link
Member Author

Comment by prksingh
Thursday Apr 02, 2015 at 10:36 GMT


@aringot For inactive pane in general line number appears highlighted. But for Nested inactive pane, line numbers have no highlight. Was this intentional?

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Thursday Sep 29, 2016 at 17:47 GMT


@aringot ping

@core-ai-bot
Copy link
Member Author

Comment by aringot
Wednesday Oct 19, 2016 at 11:06 GMT


Sorry guys, I've been pretty busy...
@prksingh , given my commit messages I got highlight even in the Nested editor. I'll try to have a look at it but I changed my laptop and OS, so I'll need to set everything up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant