Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix highlighting 10325 #10737

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

aringot
Copy link

@aringot aringot commented Mar 13, 2015

Fix for: #10325
Also discussed here : https://groups.google.com/forum/#!topic/brackets-dev/SPokrvCyh9Y

The goal of my fix is to add (actually keep) a highlight on the (now) inactive-pane focused line when you use several panes and have the "Highlight Active Line" option checked.

Here is how it looks like with the light theme :
image

With the dark theme :
image

Only the currently focused line has a line number colored differently to clearly see the difference between active and inactive pane. (and the highlight is a bit dimmer for the inactive pane)

As it is just about styles, I didn't modify any JavaScript, I only modified LESS files.
I tested that the modification was effective both on light and dark theme, for normal and inline editors.

@abose
Copy link
Contributor

abose commented Mar 25, 2015

@aringot I coudnt get this to work. I just fetched the pull request and reloaded brackets, but the active line hilights are not coming. should i do something more to get this to work?

@prksingh
Copy link
Contributor

prksingh commented Apr 2, 2015

@abose View > Highlight Active Line

@prksingh
Copy link
Contributor

prksingh commented Apr 2, 2015

@aringot For inactive pane in general line number appears highlighted. But for Nested inactive pane, line numbers have no highlight. Was this intentional?

@prksingh prksingh self-assigned this Apr 2, 2015
@ficristo
Copy link
Collaborator

@aringot ping

@aringot
Copy link
Author

aringot commented Oct 19, 2016

Sorry guys, I've been pretty busy...
@prksingh , given my commit messages I got highlight even in the Nested editor. I'll try to have a look at it but I changed my laptop and OS, so I'll need to set everything up again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants