Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests #13501

Open
core-ai-bot opened this issue Aug 31, 2021 · 8 comments
Open

Failing tests #13501

core-ai-bot opened this issue Aug 31, 2021 · 8 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ficristo
Saturday Jan 23, 2016 at 16:03 GMT
Originally opened as adobe/brackets#12144


  • Reload without extensions
  • Run Integration / WorkingSetSort and Integration / WorkingSetView
  • The tests fail

I cannot run all the test suite but I see at least these tests fail.
Can someone confirm?

@core-ai-bot
Copy link
Member Author

Comment by swmitra
Saturday Jan 23, 2016 at 16:37 GMT


Can confirm@ficristo Intergration tests are failing. I am on it right now... in order to fix the file close bug.

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Saturday Jan 23, 2016 at 16:44 GMT


Thanks@swmitra.
I saw some problems with code folding too, but I don't understand if they are influenced by some extensions (even if I realoded without them).

I find a bit scary that a release was posted with tests failing...

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Saturday Jan 23, 2016 at 17:54 GMT


@swmitra with your PR now the Integration / WorkingSetSort and Integration / WorkingSetView pass.
But there are still problems at least under Integration:

  • Document Integration
  • FindInFiles
  • FindReplace Integration

Plus I've run twice InlineEditorProviders: the first time with errors, the second without...

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Sunday Jan 24, 2016 at 16:22 GMT


@ficristo Have you looked at the Running Brackets Unit Tests wiki page? It's a known issue that running all tests at once is problematic.

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Sunday Jan 24, 2016 at 16:32 GMT


I hope@redmunds that is not an excuse to not run them.
Sorry to be harsh but lately I'm quite disillusioned about Brackets.
And yes, I realized that there are CPU/memory problems.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Sunday Jan 24, 2016 at 16:38 GMT


I hope that is not an excuse to not run them.

Absolutely not. I spent some time (a while ago) trying to get Brackets unit tests to use less memory, release memory faster, etc. but was unable to make it so running all tests was reliable, so that's why I wrote that wiki page. If anyone has any ideas on how to improve running unit tests that would be awesome.

@core-ai-bot
Copy link
Member Author

Comment by ficristo
Saturday Jul 23, 2016 at 11:27 GMT


There are still some failures on master:

  • Integration \ FindInFiles
  • Extensions \ Code Folding (this should be fixed updating CodeMirror)
  • Extensions \ SVG Code Hints

@MarcelGerber can you look at all the failures? I would prefer to have a clean situation before looking more at CodeMirror.

@core-ai-bot
Copy link
Member Author

Comment by mansimarkaur
Tuesday Sep 27, 2016 at 23:10 GMT


I'm also getting Integration failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant