Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Failing tests #12144

Open
ficristo opened this issue Jan 23, 2016 · 8 comments
Open

Failing tests #12144

ficristo opened this issue Jan 23, 2016 · 8 comments

Comments

@ficristo
Copy link
Collaborator

  • Reload without extensions
  • Run Integration / WorkingSetSort and Integration / WorkingSetView
  • The tests fail

I cannot run all the test suite but I see at least these tests fail.
Can someone confirm?

@swmitra
Copy link
Collaborator

swmitra commented Jan 23, 2016

Can confirm @ficristo Intergration tests are failing. I am on it right now... in order to fix the file close bug.

@ficristo
Copy link
Collaborator Author

Thanks @swmitra.
I saw some problems with code folding too, but I don't understand if they are influenced by some extensions (even if I realoded without them).

I find a bit scary that a release was posted with tests failing...

swmitra added a commit that referenced this issue Jan 23, 2016
@ficristo
Copy link
Collaborator Author

@swmitra with your PR now the Integration / WorkingSetSort and Integration / WorkingSetView pass.
But there are still problems at least under Integration:

  • Document Integration
  • FindInFiles
  • FindReplace Integration

Plus I've run twice InlineEditorProviders: the first time with errors, the second without...

@redmunds
Copy link
Contributor

@ficristo Have you looked at the Running Brackets Unit Tests wiki page? It's a known issue that running all tests at once is problematic.

@ficristo
Copy link
Collaborator Author

I hope @redmunds that is not an excuse to not run them.
Sorry to be harsh but lately I'm quite disillusioned about Brackets.
And yes, I realized that there are CPU/memory problems.

@redmunds
Copy link
Contributor

I hope that is not an excuse to not run them.

Absolutely not. I spent some time (a while ago) trying to get Brackets unit tests to use less memory, release memory faster, etc. but was unable to make it so running all tests was reliable, so that's why I wrote that wiki page. If anyone has any ideas on how to improve running unit tests that would be awesome.

@ficristo
Copy link
Collaborator Author

There are still some failures on master:

  • Integration \ FindInFiles
  • Extensions \ Code Folding (this should be fixed updating CodeMirror)
  • Extensions \ SVG Code Hints

@marcelgerber can you look at all the failures? I would prefer to have a clean situation before looking more at CodeMirror.

@mansimarkaur
Copy link
Contributor

I'm also getting Integration failures.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants
@redmunds @ficristo @swmitra @mansimarkaur and others