[CLOSED] fix 5110: Switching to other file while Live Development is connecting causes it to fail

[core-ai-bot]

Issue by couzteau
Thursday Sep 19, 2013 at 18:22 GMT
Originally opened as adobe/brackets#5268

---

ensure _doLaunchAfterServerReady uses the document that was current when the GoLive command

---

couzteau included the following code: https://github.com/adobe/brackets/pull/5268/commits

[core-ai-bot]

Comment by peterflynn
Tuesday Sep 24, 2013 at 00:56 GMT

---

@ingorichter This covers one of the changes I made in my pflynn/indexhtml-hack branch. Nice...

[core-ai-bot]

Comment by njx
Tuesday Sep 24, 2013 at 01:03 GMT

---

I'm not super familiar with the logic in this area, but the fix makes sense.

I wonder if it would be worth adding unit tests around some of these kinds of order-of-operations issues. I know we've talked about it in the past, and it's tricky because we'd really need to mock a lot of stuff out, I think--and maybe it's not worth it in that case because it wouldn't really be testing real-world cases, just our internal logic. But that can be valuable too since it could give us greater confidence that new changes won't break those things.

Anyway, I won't let that hold up this pull request :)