This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
fix 5110: Switching to other file while Live Development is connecting causes it to fail #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… current when the GoLive command
ghost
assigned 
|
@ingorichter This covers one of the changes I made in my pflynn/indexhtml-hack branch. Nice... |
|
I'm not super familiar with the logic in this area, but the fix makes sense. I wonder if it would be worth adding unit tests around some of these kinds of order-of-operations issues. I know we've talked about it in the past, and it's tricky because we'd really need to mock a lot of stuff out, I think--and maybe it's not worth it in that case because it wouldn't really be testing real-world cases, just our internal logic. But that can be valuable too since it could give us greater confidence that new changes won't break those things. Anyway, I won't let that hold up this pull request :) |
njx
added a commit
that referenced
this pull request
Sep 24, 2013
fix 5110: Switching to other file while Live Development is connecting causes it to fail
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure _doLaunchAfterServerReady uses the document that was current when the GoLive command