Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline images #8

Open
pejuko opened this issue Jul 9, 2015 · 5 comments
Open

Inline images #8

pejuko opened this issue Jul 9, 2015 · 5 comments

Comments

@pejuko
Copy link

pejuko commented Jul 9, 2015

Does griddle-mailgun support inline images? Mailgun creates content-id-map which I don't see when I use griddler-mailgun. I need to link inline images referenced by cid to attachment but the Content-ID is not presented between headers.

@bradpauly
Copy link
Owner

It doesn't right now. It supports the attributes defined by https://github.com/thoughtbot/griddler

I'm pretty sure you could get that out of the headers. Did you try that?

pejuko added a commit to pejuko/griddler-mailgun that referenced this issue Jul 10, 2015
@pejuko
Copy link
Author

pejuko commented Jul 10, 2015

Yes I did, but Content-ID is missing in headers because mailgun deletes them from headers and they are creating their own param content-id-map :-/ I've added support for this so you can get content-id-map as hash from params now.

@pejuko
Copy link
Author

pejuko commented Jul 10, 2015

Hm, I extended the param but this is probably wrong as it is private. Any ideas how to get content-id-map into email?

pejuko added a commit to pejuko/griddler-mailgun that referenced this issue Jul 10, 2015
@bradpauly
Copy link
Owner

I'll try to take a look at this next week.

@pejuko
Copy link
Author

pejuko commented Jul 12, 2015

Ok. Thanks. No hurry. I've solved this already in my second commit and it is working for me now. If this solution is ok for you, you can merge it or write me and I'll refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants