Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/spin bivector #205

Merged
merged 19 commits into from
Nov 30, 2023
Merged

Features/spin bivector #205

merged 19 commits into from
Nov 30, 2023

Conversation

brainandforce
Copy link
Owner

This adds a new SpinBivector type that represents a spin plane. This can be useful when working with spin planes noncollinear to a lattice direction.

@brainandforce
Copy link
Owner Author

I really don't understand this:

Ambiguity #5
getindex(a::StaticArraysCore.StaticArray, ::Colon) @ StaticArrays ~/.julia/packages/StaticArrays/yXGNL/src/indexing.jl:104
getindex(b::Electrum.SpinBivector, i...) @ Electrum ~/work/Electrum.jl/Electrum.jl/src/data/spin.jl:94

Possible fix, define
  getindex(::Electrum.SpinBivector, ::Colon)

because this ambiguity doesn't exist for Electrum.LatticeBasis

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (94a3884) 60.16% compared to head (668e1de) 61.06%.

Files Patch % Lines
src/data/spin.jl 92.68% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   60.16%   61.06%   +0.89%     
==========================================
  Files          21       21              
  Lines        1446     1487      +41     
==========================================
+ Hits          870      908      +38     
- Misses        576      579       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce merged commit 1777e86 into main Nov 30, 2023
7 checks passed
@brainandforce brainandforce deleted the features/spin-bivector branch November 30, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant