Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CoordinateVector to represent coordinates in real/reciprocal space #210

Merged
merged 36 commits into from
Dec 10, 2023

Conversation

brainandforce
Copy link
Owner

These types should allow for more rigorous work with spatial coordinates in this package.

The ShiftVector type has been changed to wrap a CoordinateVector.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (3146adb) 60.05% compared to head (9fd767e) 61.06%.

Files Patch % Lines
src/vectors.jl 88.88% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
+ Coverage   60.05%   61.06%   +1.01%     
==========================================
  Files          23       23              
  Lines        1562     1613      +51     
==========================================
+ Hits          938      985      +47     
- Misses        624      628       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brainandforce brainandforce merged commit 5526028 into main Dec 10, 2023
7 checks passed
@brainandforce brainandforce deleted the features/coordinates branch December 10, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant