Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChatVertexAI #124

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Add ChatVertexAI #124

merged 6 commits into from
Jun 6, 2024

Conversation

raulchedrese
Copy link
Contributor

Here is my first crack at a a ChatVertexAI module. I'm currently using this module in production with good results.

I adapted the tests from the existing ChatGoogleAI module.

I also have a fix in here for an issue I ran into when using OpenAI through Azure. I don't know that this is an ideal way to deal with the issue though. Let me know if you want me to remove that fix from this PR.

Copy link
Owner

@brainlid brainlid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looking over the ChatVertextAI module looks good. Thanks!

lib/chains/llm_chain.ex Outdated Show resolved Hide resolved
Copy link
Owner

@brainlid brainlid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping to finalize the changes! Let's try this out let others bang on it too.

Thanks!
❤️💛💙💜

@brainlid brainlid merged commit 899aacd into brainlid:main Jun 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants