Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support language, function and procedure object types in redshift_grant resource #57

Merged
merged 3 commits into from
Apr 20, 2022

Conversation

pawelaugustyn
Copy link
Contributor

@pawelaugustyn pawelaugustyn commented Mar 2, 2022

Separate REVOKE for languages as doc doesn't specify all privileges could be revoked
Additional checks for the length of objects/privileges arrays in case language is selected object type
GRANT and REVOKE docs

Not quoting functions'/procedures' names when passing to GRANT/REVOKE queries as it doesn't work.

[DEBUG] Created GRANT query: GRANT execute ON PROCEDURE "tf_acc_schema_basic_8011988112360987093"."test_proc()" TO GROUP "tf_acc_group_basic_2027694401778663218"
2022/03/02 10:25:46 [WARN] Got error running Terraform: exit status 1

Error: pq: syntax error at or near "TO"

  with redshift_grant.grant_fun,
  on terraform_plugin_test.tf line 10, in resource "redshift_grant" "grant_fun":
  10: resource "redshift_grant" "grant_fun" {

Resolves #34
Resolves #45

@pawelaugustyn pawelaugustyn linked an issue Mar 2, 2022 that may be closed by this pull request
@pawelaugustyn pawelaugustyn force-pushed the grant-extend-supported-object-types branch from 43c27fa to b7b5cef Compare March 9, 2022 09:34
@winglot winglot merged commit be6e0d9 into master Apr 20, 2022
@winglot winglot added the enhancement New feature or request label Apr 21, 2022
@szemek szemek deleted the grant-extend-supported-object-types branch November 15, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redshift_grant resource does not support language object Ability to grant EXECUTE function
2 participants