Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test of rates #386

Merged
merged 3 commits into from
Jun 20, 2023
Merged

Test of rates #386

merged 3 commits into from
Jun 20, 2023

Conversation

shangyangli
Copy link
Contributor

No description provided.

@chaoming0625
Copy link
Collaborator

The tests have failed. Before merging this PR, you should fix the errors first.

Particularly, the bug fixing should be:

@chaoming0625
Copy link
Collaborator

At the line of

if bm.any(self.noise_i != 0.):

change it as:

with jax.ensure_compile_time_eval():
  has_noise = bm.any(self.noise_i != 0.)

if has_noise:
  ...

Similarly, at the line of ```` if bm.any(self.noise_e != 0.):``, change it as:

with jax.ensure_compile_time_eval():
  has_noise = bm.any(self.noise_e != 0.)

if has_noise:
  ...

@chaoming0625
Copy link
Collaborator

@ztqakita Please help @shangyangli to pass all tests. We cannot merge any PR with test errors.

Copy link
Collaborator

@ztqakita ztqakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ztqakita ztqakita merged commit 488eff6 into brainpy:master Jun 20, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants