Allow Manual Browser Switch Handling #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
force-pushed
the
allow_manual_browser_switch_handling
branch
from
b5909d6
to
07d947c
Compare
sshropshire
force-pushed
the
allow_manual_browser_switch_handling
branch
from
07d947c
to
9f0b2d2
Compare
…ate BraintreeClient only constructor and onBrowserSwitchResult with callback method.
Signed-off-by: Jax DesMarais-Leder <[email protected]>
sshropshire
force-pushed
the
allow_manual_browser_switch_handling
branch
from
91ba131
to
593a145
Compare
sshropshire
changed the title
| @@ -32,7 +33,7 @@ public class LocalPaymentClient { | |||
| /** | |||
| * Create a new instance of {@link LocalPaymentClient} from within an Activity using a {@link BraintreeClient}. | |||
| * | |||
| * @param activity a {@link FragmentActivity} | |||
| * @param activity a {@link FragmentActivity} | |||
There was a problem hiding this comment.
The spacing for this looks different then the braintreeClient right below. Is this intentional?
There was a problem hiding this comment.
Yeah it's the auto formatter in Android studio. We would need to run it on each file for 100% consistency.
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors