Changing merchant id for native checkout nonce requests #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelay858
commented
Aug 10, 2023
| @@ -97,6 +100,9 @@ public void failure(RetrofitError error) { | |||
| transactionRequest = new TransactionRequest(amount, nonceString, unionPayMerchantAccountId); | |||
| } else { | |||
| String merchantAccountId = Settings.getMerchantAccountId(activity); | |||
| if (merchantAccountId == null && nonce instanceof PayPalNativeCheckoutAccountNonce) { | |||
| merchantAccountId = PAYPAL_NATIVE_CHECKOUT_CLIENT_ID; | |||
There was a problem hiding this comment.
since we create the ba token with this client id we need to execute the transaction with it as well
ghbhatt
reviewed
Aug 11, 2023
| @@ -8,6 +8,7 @@ | |||
| import com.braintreepayments.api.PostalAddress; | |||
|
|
|||
| public class PayPalNativeCheckoutRequestFactory { | |||
| public static final String PAYPAL_NATIVE_CHECKOUT_CLIENT_ID = "NativeXOTest"; | |||
There was a problem hiding this comment.
should we name this PAYPAL_NATIVE_CHECKOUT_MERCHANT_ID?
There was a problem hiding this comment.
yeah i will switch to merchant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Braintree.
Summary of changes
Checklist
Authors