add Dankort support #106
Closed
add Dankort support #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassiocardoso
commented
May 2, 2020
Comment on lines
+137
to
+138
| [5000, 5018], | ||
| [502000, 506698], |
There was a problem hiding this comment.
I split the patterns here to make 5019 Dankort-exclusive. This didn't affect the other unit tests for Maestro.
|
We can't accept this without official documentation about the dankort ranges. Please provide that. |
|
Hey @crookedneighbor I thought this references would be enough from your comments on the thread |
|
LOL, you're right. Totally forgot the reference was in the original issue. |
|
haha no worries :) |
gesa
reviewed
May 5, 2020
Co-authored-by: Aki <[email protected]>
Co-authored-by: Aki <[email protected]>
|
Hi @gesa, thanks for your review! Sounds good to me, let me know once the TS migration is merged and I can update this one :) |
|
The typescript migration is complete. |
|
Going to close this for now, but once you've merged in master, feel free to open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I was working on integrating this lib into another one that I'm maintaining and noticed that you had the Dankort issue flag tagged as
help wanted, so here it is. 😄Since the changes are mostly in the card configuration and docs, I think this won't have a negative impact on the TS migration you've been working on.
Let me know if there's anything else needed.
Proposal
Add
Dankortsupport. (closes #100)Details
Dankorttype.