Remove spaces to accurately match a unionpay card type #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibooker
reviewed
Sep 4, 2024
| @@ -112,6 +112,7 @@ describe("creditCardType", () => { | |||
| ["353445444300732639", "jcb"], | |||
| ["3537286818376838569", "jcb"], | |||
|
|
|||
| ["6222 8212 0000 0000", "unionpay"], | |||
There was a problem hiding this comment.
I'd suggest adding test cases (with spaces) for the other major card types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue today where a card entered with the prefix
6222 8212, that is including spaces, matched as a maestro card, but should've instead matched as a union pay card. I suspect this might be a wider issue than just these two types. I think to accurately match the types we should be removing the spaces, as they have no bearing on card type.