Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Pre-Acceptance: Set default method, return 500s on broken path regex. #174

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Minor Pre-Acceptance: Set default method, return 500s on broken path regex. #174

merged 2 commits into from
Jun 28, 2022

Conversation

ibihim
Copy link
Collaborator

@ibihim ibihim commented Jun 23, 2022

What

  • Add explicit default method for resourceAttributes. The behavior shouldn't change.
  • Return an internal error on misconfigured regex. Shouldn't change behavior. As it is checked during parsing.

Why

  • An unspecified method could make it harder to understand, why a SAR gets rejected.
  • It is safer to handle the error case with a 500, even thought is currently can't happen.

Ref

#169

@ibihim ibihim requested a review from s-urbaniak June 23, 2022 15:09
@s-urbaniak s-urbaniak merged commit 50a7e88 into brancz:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibihim @s-urbaniak