Add support for shortcuts #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevented the editing of cards, as the same activity was used for viewing and editing, but the viewing "instance" was calling finish(). It is simpler to remove the singleTop option. This reverts commit 4e02252.
Card IDs for new cards will soon need to be known once they are created. This change updates this call to return the new id.
When a card is being added or created, a checkbox will now be presented asking if a shortcut should be made. If selected, when saving a shortcut will be added to the home screen. The shortcut will directly launch the given card in view mode.
This is largely unneeded, as shortcuts are directly supported now, and the widget was a hacky replacement for shortcuts. This reverts commit ebe6139.
Some of these will need to be accessed prior to onResume()
The global variables have the same information; no need to look up the information again.
This will prevent shortcuts from creating many views, and causing them to leak. However, do not use singleTop for all launches of the view activity, else the edit mode cannot be entered.
When a shortcut launches the view activity, if the activity already exists it will get onNewIntent() called. This needs to clear out the view items so the next card will be redrawn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#154