Support SEND intent #106
Merged
Support SEND intent #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the app to handle SEND intents, which send data to the app for processing. ffmpeg, which encodes the files, must process a file path instead of a stream. Because of this, the data in the intent must be saved locally first then staged for processing. As soon as the SEND intent is received the data is copied over, then a preview posted to the user. There are a few aspects which are not yet resolved, such as posting a permissions dialog if the app does not have the permissions yet, and the sent file's name is not preserved so the output name makes sense.
Previously there was only one reason for a permission check, namely to select a video. However, there are now ENCODE and SEND intent which need to be handled. To reduce the complexity of handling what is requesting the permission, a callback is now being handed to getPermission() which will invoke it if the read/write permissions are granted.
Previously the file name of the input file was used as the basis of the output file name. However, because the file from a SEND intent is saved to a tmp file, its name is meaningless. This change will preserve the name so it can be used to label the output file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42