Lower the min sdk to 19 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The min sdk was increased to 21 because JobService was being used. Since, that has been removed, so the app should work on sdk 19. The sdk could be lower yet, as the app did compile on sdk 16. However, unless someone is interested in trying that out on a device, sdk 19 is fine for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The min sdk was increased to 21 because JobService was being used.
Since, that has been removed, so the app should work on sdk 19.
The sdk could be lower yet, as the app did compile on sdk 16. However,
unless someone is interested in trying that out on a device, sdk 19
is fine for now.