Video selection #24
Merged
Video selection #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
brarcher
commented
Jan 27, 2018
brarcher
commented
- Report FFmpeg errors to user
- Add ability to better select specific parts of a video with the sliders
Forward and backward buttons for the start and end of the timing slider are being added, to fine control the window.
If the video were canceled when the app was brought back and encoding was not processing in the backgroud but there was a job to process, then the cancel callback will never occur. To let the buttons for video selection to be shown in this case, unconditionally show them after a cancel.
brarcher
force-pushed
the
video-selection
branch
from
9be30f9
to
94a9b1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.