Add intent for encoding file #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One part, with no argument, will take the encode parameters from the UI and use them. The second part will accept parameters and start encoding. This change will be relevant soon when an intent can also start encode, which provides its own arguments.
ffprobe can output media info in json format, which makes parsing easier and less brittle. As the the FFmpeg Android library includes ffprobe, make use of it.
This is to allow for automated testing using the ENCODE intent interface.
This test does not check all supported formats, and does not do any validation on the encoded file to ensure it was what was asked for. For now, all this test does is show that the arguments were accepted and that something was produced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an intent to the app which can be used to request that a file be encoded without selecting options. The intent is called
protect.videotranscoder.ENCODE, and takes the following arguments:String inputVideoFilePath: Path to input video file
String outputFilePath: Path to output video/audio file
String mediaContainer: The output media container. Examples: flv, mkv, mp4, gif, mp3, ogg
If the media container supports video, the following are required:
String videoCodec: Video codec to use, must be supported by media container. Example: h264, mpeg4, mpeg2video, gif
Integer videoBitrateK: Bitrate to use for video stream, in 1000s of bits per second. Example: 2000
String resolution: Screen resolution of video stream. Example: 270x460
String fps: Frame per second. Can be an integer or floating number. Examples: 25, 19.01.
If the media container supports audio, the following are required:
String audioCodec: Audio codec to use, must be supported by media container. Example: aac, vorbis, mp3, none (ignores audio).
Integer audioSampleRate: Samples per second. Example: 22050
Integer audioBitrateK: Bitrate used for audio stream, in 1000s of bits per second. Example: 128.
String audioChannel: Number of channels used for audio. Example: 1, 2.
Example of encoding a video:
This will result in a dialog asking for confirmation:
When encoding is complete a dialog is shown giving a summary and an option to send the file elsewhere:
This support should not be relied on and should be considered "alpha".
In addition, a simple shell script test is added which uses the intent interface to request several test files be encoded with various options.