Skip palette generation step when converting to gif #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GIF files only support 256 colors. Previously a pass over the input video was taken to develop a good color palette before converting to gif. However, it was found that on a recent FFmpeg version that the palette generation step was taking a significant amount of memory and time to complete. For non-trivial videos it was not possible to create a gif. This change removes the palette generation step. This will likely cause the color quality of the output gif to decrease, however it should be much quicker to generate the gif.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIF files only support 256 colors. Previously a pass over the input
video was taken to develop a good color palette before converting
to gif. However, it was found that on a recent FFmpeg version that
the palette generation step was taking a significant amount of
memory and time to complete. For non-trivial videos it was not
possible to create a gif.
This change removes the palette generation step. Instead, a default
palette that FFmpeg defines is used. This will likely
cause the color quality of the output gif to decrease, however
it should be much quicker to generate the gif.
If the quality of the generated gif files is not that great, here are some options
to improving the quality:
http://blog.pkh.me/p/21-high-quality-gif-with-ffmpeg.html
#67