Skip to content

Commit

Permalink
add npm command for running a network audit
Browse files Browse the repository at this point in the history
'npm run network-audit' produces a JSON file,
network-audit-results.json, which contains the URL requests and 307's in
the current build.
  • Loading branch information
diracdeltas committed Oct 18, 2018
1 parent 8beea4e commit 75f97ea
Show file tree
Hide file tree
Showing 4 changed files with 33 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ npm-debug.log
.vscode
.cipd
.idea
network_log.json
network-audit-results.json

# Rendered Sphinx files should be excluded from source control
build
Expand Down
30 changes: 29 additions & 1 deletion lib/start.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const path = require('path')
const fs = require('fs-extra')
const config = require('../lib/config')
const util = require('../lib/util')

Expand Down Expand Up @@ -44,8 +45,8 @@ const start = (buildConfig = config.defaultBuildConfig, options) => {
if (options.rewards_reconcile_interval) {
braveArgs.push(`--rewards-reconcile-interval=${options.rewards_reconcile_interval}`)
}
let user_data_dir
if (options.user_data_dir_name) {
let user_data_dir
if (process.platform === 'darwin') {
user_data_dir = path.join(process.env.HOME, 'Library', 'Application\\ Support', 'BraveSoftware', options.user_data_dir_name)
} else if (process.platform === 'win32') {
Expand All @@ -55,19 +56,46 @@ const start = (buildConfig = config.defaultBuildConfig, options) => {
}
braveArgs.push('--user-data-dir=' + user_data_dir);
}
const networkLogFile = path.resolve(path.join(__dirname, '..', 'network_log.json'))
if (options.network_log) {
braveArgs.push(`--log-net-log=${networkLogFile}`)
braveArgs.push(`--net-log-capture-mode=IncludeSocketBytes`)
if (user_data_dir) {
// clear the data directory before doing a network test
console.log('clearing user data directory', user_data_dir)
fs.removeSync(user_data_dir)
}
}

let cmdOptions = {
stdio: 'inherit',
timeout: options.network_log ? 10000 : undefined,
shell: true
}

if (process.platform === 'darwin') {
util.run(path.join(config.outputDir, config.macAppName() + '.app', 'Contents', 'MacOS', config.macAppName()), braveArgs, cmdOptions)
/*
util.run('/Applications/Brave\\ Browser.app/Contents/MacOS/Brave\\ Browser',
braveArgs, cmdOptions)
*/
} else if (process.platform === 'win32') {
util.run(path.join(config.outputDir, 'brave.exe'), braveArgs, cmdOptions)
} else {
util.run(path.join(config.outputDir, 'brave'), braveArgs, cmdOptions)
}

if (options.network_log) {
// Read the network log
const jsonOutput = fs.readJsonSync(networkLogFile)
const URL_REQUEST_TYPE = jsonOutput.constants.logSourceType.URL_REQUEST
const URL_REQUEST_FAKE_RESPONSE_HEADERS_CREATED = jsonOutput.constants.logEventTypes.URL_REQUEST_FAKE_RESPONSE_HEADERS_CREATED
const urlRequests = jsonOutput.events.filter((event) =>
(event.source.type === URL_REQUEST_TYPE && event.params && event.params.url && event.params.url.startsWith('http')) || event.type === URL_REQUEST_FAKE_RESPONSE_HEADERS_CREATED
)
// TODO: parse this and fail travis if it includes unexpected events
fs.writeJsonSync('network-audit-results.json', urlRequests)
}
}

module.exports = start
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"update_patches": "node ./scripts/commands.js update_patches",
"apply_patches": "node ./scripts/sync.js --run_hooks",
"start": "node ./scripts/commands.js start",
"network-audit": "node ./scripts/commands.js start --network_log --user_data_dir_name=brave-network-test",
"push_l10n": "node ./scripts/commands.js push_l10n",
"pull_l10n": "node ./scripts/commands.js pull_l10n",
"chromium_rebase_l10n": "node ./scripts/commands.js chromium_rebase_l10n",
Expand Down
1 change: 1 addition & 0 deletions scripts/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ program
.option('--rewards_env [server]', 'switch between staging and production', /^(stag|prod)$/i)
.option('--rewards_reconcile_interval [reconcile_interval]', 'set reconcile interval for contribution in minutes', parseInt)
.option('--single_process', 'use a single process')
.option('--network_log', 'log network activity to network_log.json')
.arguments('[build_config]')
.action(start)

Expand Down

0 comments on commit 75f97ea

Please sign in to comment.