Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] 2nd AC amount is not shown in summary and monthly statement #10149

Closed
GeetaSarvadnya opened this issue Jun 8, 2020 · 5 comments
Closed
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 8, 2020

Description

Found while testing brave/brave-core#5728
2nd AC amount is not shown in summary and monthly statement. However, the 2nd AC amount and breakup for verified pubs is shown correctly in brave://rewards-internals under Contributions

Steps to Reproduce

  1. Clean profile 1.12.8 staging env
  2. Launch brave using brave.exe --enable-logging --vmodule="*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/bat-native-ledger/*"=6 --rewards=staging=true,reconcile-interval=3,short-retries=true
  3. Enable rewards
  4. Connect KYC'd staging wallet which should have balance ( my balance was 15 BAT)
  5. Add 3 verified pubs to AC table (DDG, https://www.3zsistemi.si/ and laurenwags.github.io)
  6. Wait for reconcile interval
  7. AC is triggered, AC notification is shown and AC amount is shown in summary and monthly statement
  8. Trigger AC 2nd time, add the same pubs which are added in step 5
  9. Send monthly tips to 3zsistemi and laurenwags.github.io
  10. Send a one time tip to 3zsistemi
  11. Wait for 2nd AC
  12. AC is triggered, wallet balance got reduced, AC notification isn't shown on BAT logo. 2nd AC amount is not shown in summary and monthly statement. However, the 2nd AC amount and breakup for verified pubs is shown correctly in brave://rewards-internals under Contributions

Actual result:

2nd AC amount is not shown in summary and monthly statement

Expected result:

2nd AC amount should be shown in summary and monthly statement

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.12.8 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @NejcZdovc @LaurenWags

1st time AC amount 5 BAT ---> 20*0.25 = 5 BAT (20 unblinded tokens redeemed in DB as expected)
2nd time AC amount 3.25 BAT--->13*0.25 =3.25 BAT( 13 unblinded tokens redeemed_at and redeemed_id is empty in DB)
image

@zenparsing
Copy link

@GeetaSarvadnya I was not able to reproduce on Mac with Nightly (1.14). When you get a chance, can you see if the issue repros for you in 1.14?

@NejcZdovc NejcZdovc added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Aug 17, 2020
@LaurenWags
Copy link
Member

@GeetaSarvadnya when you retry per @zenparsing request in #10149 (comment), might be worth trying both with and without short-retries flag since we know that causes issues.

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 15, 2021

@pes10k reproduced this today (January 14, 2021). Does not and never had a verified wallet.

@urbenlegend
Copy link

Is this related to the issue I am experiencing here? https://community.brave.com/t/brave-auto-contribute-stuck-at-prepare-step/165794

AC attempts to contribute BAT but gets stuck on a few sites. This makes the whole contribution "wait" and the contribution is never shown in the monthly statements.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jan 29, 2021

@zenparsing @LaurenWags The issue isn't reproducible in Windows 10 x64 - 1.19.88. I have triggered two uphold Auto-Contributions, 1st AC with 20 BAT and 2nd AC is with 5 BAT. AC amount is shown in Summary, Monthly statement, and brave://rewards-internals. Unblinded tokens are redeemed correctly, the total AC amount is 25 BAT. 100 unblinded tokens are recorded in the unblinded_tokens table i.e 100*0.25 = 25 BAT.


Brave | 1.19.88 Chromium: 88.0.4324.96 (Official Build) (64-bit)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

image
image
image

@Miyayes Miyayes closed this as completed Nov 22, 2022
@Miyayes Miyayes added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards needs-more-info The report requires more detail before we can decide what to do with this issue. OS/Desktop QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

6 participants