Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards needs a 'waiter' message when opting in. #1099

Closed
jasonrsadler opened this issue Sep 12, 2018 · 2 comments · Fixed by brave/brave-core#580
Closed

Brave Rewards needs a 'waiter' message when opting in. #1099

jasonrsadler opened this issue Sep 12, 2018 · 2 comments · Fixed by brave/brave-core#580

Comments

@jasonrsadler
Copy link

jasonrsadler commented Sep 12, 2018

Description

On first run of browser when enabling Rewards, it is difficult to tell if the browser is responding while waiting for URL responses. Recommending to add a 'please wait' type of message. Also prevent multiple clicking of 'Opt In' (only the first click however, has any effect)

Steps to Reproduce

  1. Open Brave on clean profile
  2. Enable Rewards
  3. Observe length of time from 'Opt In' click until the main Rewards page is displayed.

Actual result:

Rewards page 'lags' a response

Expected result:

The Rewards page should immediately acknowledge that the 'Opt In' button was pressed with a 'waiter' message

Reproduces how often:

Always

Brave version (chrome://version info)

Brave | 0.55.2 Chromium: 70.0.3538.12 (Developer Build) (64-bit)
Revision | ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS | Mac OS X

Reproducible on current release:

Yes

Website problems only:

~~~- Is the issue reproducible on the latest version of Chrome?~~~

### Additional Information
<!--Any additional information, related issues, extra QA steps, configuration or data that might be necessary to reproduce the issue-->
@NejcZdovc
Copy link
Contributor

friendly ping to @jenn-rhim for the spinning icon that we talked about 😃

@bbondy bbondy added this to the 1.x Backlog milestone Sep 22, 2018
@rebron rebron modified the milestones: 1.x Backlog, 1.0 (0.56.x) Sep 28, 2018
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. browser-laptop-parity labels Sep 28, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0 (0.56.x), Releasable builds 0.55.x Oct 8, 2018
@NejcZdovc NejcZdovc self-assigned this Oct 8, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 8, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 10, 2018

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux
  • Verified Creating wallet spinner is shown when wallet is getting created
  • Verified Total line is not shown when amount is added/importing a wallet

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X

Verification passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants