Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop][CW] Locking account throws error #11272

Closed
srirambv opened this issue Aug 17, 2020 · 4 comments
Closed

[Desktop][CW] Locking account throws error #11272

srirambv opened this issue Aug 17, 2020 · 4 comments

Comments

@srirambv
Copy link
Contributor

Description

Similar to #11269, creating an account and clicking on Lock throws the same error message

Steps to Reproduce

  1. Create a new wallet
  2. Open Account menu
  3. Click lock, page throws error. Try reloading same error

Actual result:

image

Expected result:

Should lock out of the current session

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.13.69 Chromium: 84.0.4147.125 (Official Build) beta (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS Linux
Component MM v8 rebase

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? NA

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@srirambv
Copy link
Contributor Author

This also happens if you close the browser and restart it

ryanml added a commit to brave/ethereum-remote-client that referenced this issue Aug 17, 2020
ryanml added a commit to brave/ethereum-remote-client that referenced this issue Aug 17, 2020
… logo fix, Using correct keyring controller version
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.13.69 Chromium: 84.0.4147.125 (Official Build) beta (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{# 1059}
OS Linux
Component MM v8 rebase
  • Verified error page is not shown when locking the account
  • Verified closing and relaunching the page doesn't show the error page

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.12.114 Chromium: 84.0.4147.135 (Official Build) (64-bit)
Revision c42bd09b3f24da1698d71d3b4f57402137163566-refs/branch-heads/4147@{#1102}
OS Windows 10 OS Version 1809 (Build 17763.1397)
Component 0.1.67
  • Verified error page is not shown when locking the account
  • Verified closing and relaunching the page doesn't show the error page

Verification passed on

Brave 1.13.75 Chromium: 85.0.4183.69 (Official Build) beta (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Linux
Component 0.1.67
  • Verified error page is not shown when locking the account
  • Verified closing and relaunching the page doesn't show the error page

Verification passed on

Brave 1.14.55 Chromium: 85.0.4183.69 (Official Build) nightly (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS macOS Version 10.15.5 (Build 19F101)
Component 0.1.67
  • Verified error page is not shown when locking the account
  • Verified closing and relaunching the page doesn't show the error page

@srirambv
Copy link
Contributor Author

Fixed via brave/ethereum-remote-client@b6a9d98

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant