Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Follow up #11210] Sync not working message showing up on private tabs #11363

Closed
srirambv opened this issue Aug 21, 2020 · 2 comments · Fixed by brave/brave-core#6480

Comments

@srirambv
Copy link
Contributor

Description

[Follow up #11210] Sync not working message showing up on private tabs

Steps to reproduce

  1. Install 1.15.2
  2. Open a new private tab
  3. Shows Sync isn't working message

Actual result

Sync isn't working message on private tab

Expected result

Should not show sync message

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? NA

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.15.2

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@AlexeyBarabash
Copy link
Contributor

Modified milestone to Nightly as it is merged to Nightly only.

@srirambv
Copy link
Contributor Author

srirambv commented Sep 2, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.83 x64 build

  • Verified no sync message is shown when opening a normal tab or a private tab on a clean install
  • Verified no sync message is shown when opening a normal tab or a private tab when upgrading from an older build
  • Verified no sync message is shown irrespective of sync is being enabled or disabled on an upgrade install

Verification passed on Samsung Tab A with Android 10 running 1.13.83 x64 build

  • Verified no sync message is shown when opening a normal tab or a private tab on a clean install
  • Verified no sync message is shown when opening a normal tab or a private tab when upgrading from an older build
  • Verified no sync message is shown irrespective of sync is being enabled or disabled on an upgrade install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants