Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled (uplift to 1.14.x) #6510

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled (uplift to 1.14.x) #6510

merged 1 commit into from
Aug 27, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Aug 26, 2020 •
edited by kjozwiak
Loading

Uplift of #6480

Resolves brave/brave-browser#11210, brave/brave-browser#11077, brave/brave-browser#11363

Created manually

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash
Merge pull request #6480 from brave/android_sync_fix_11363
b71eef6 
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled
@AlexeyBarabash AlexeyBarabash added feature/sync CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 26, 2020
@AlexeyBarabash AlexeyBarabash requested a review from a team August 26, 2020 07:38
@AlexeyBarabash AlexeyBarabash self-assigned this Aug 26, 2020
@AlexeyBarabash
Copy link
Contributor Author

Android CI is green

@kjozwiak kjozwiak added this to the 1.14.x - Beta milestone Aug 27, 2020
kjozwiak
kjozwiak approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.14.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6400 (comment).

@kjozwiak kjozwiak merged commit 5305c57 into 1.14.x Aug 27, 2020
@kjozwiak kjozwiak deleted the pr6480_android_sync_fix_11363_1.14.x branch August 27, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/sync
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak