Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] MacOS right command key closes bookmarks bar folders when omnibox is in focus #11687

Open
dentistformyeye opened this issue Sep 12, 2020 · 3 comments
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome

Comments

@dentistformyeye
Copy link

dentistformyeye commented Sep 12, 2020

Description

When the omnibox is in focus, opening a folder from the bookmarks bar, including the overflow folder, then pressing the right command key on a MacOS keyboard closes the folder and any outer folders. The left command key behaves as expected.

Steps to Reproduce

  1. Click the omnibox. Click to open a bookmarks folder.
  2. While holding the left command key, click a bookmark in the folder.
  3. Tap the right command key.

Actual result:

Step 2 works as expected. Step 3 closes the folder.

Expected result:

Step 2 opens the clicked bookmark in a new tab but doesn't close the folder. Step 3 does nothing.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.13.82 Chromium: 85.0.4183.83 (Official Build) (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS macOS Version 10.15.6 (Build 19G73)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Haven't tried.
  • Can you reproduce this issue with the beta channel? Haven't tried.
  • Can you reproduce this issue with the nightly channel? Haven't tried.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? Haven't tried.

Miscellaneous Information:

@dentistformyeye dentistformyeye changed the title [Desktop] MacOS right command key closes bookmarks bar folders [Desktop] MacOS right command key closes bookmarks bar folders on NTP Sep 15, 2020
@dentistformyeye dentistformyeye changed the title [Desktop] MacOS right command key closes bookmarks bar folders on NTP [Desktop] MacOS right command key closes bookmarks bar folders when address bar is in focus Sep 15, 2020
@dentistformyeye dentistformyeye changed the title [Desktop] MacOS right command key closes bookmarks bar folders when address bar is in focus [Desktop] MacOS right command key closes bookmarks bar folders when omnibox is in focus Sep 15, 2020
@rebron rebron added repros-on-chrome priority/P5 Not scheduled. Don't anticipate work on this any time soon. Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix labels Oct 30, 2020
@rebron
Copy link
Collaborator

rebron commented Oct 30, 2020

This repros in Chrome. Can wait for an upstream fix when addressed with a chromium update.

@bsclifton
Copy link
Member

@dentistformyeye do you know if this is still an issue? I didn't see this issue specifically in Chromium bug tracker, but I saw some similar ones that were fixed with Chromium 88. It might be fixed

@dentistformyeye
Copy link
Author

It's still happening for me on Brave version 1.19.92 (CR 88.0.4324.152). It also happens on another Chromium browser I use that's on a slightly earlier version of 88.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix OS/Desktop priority/P5 Not scheduled. Don't anticipate work on this any time soon. repros-on-chrome
Projects
Status: P5 Backlog / waiting upstream
Development

No branches or pull requests

3 participants