Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site banner doesn't auto resize based on browser size #1658

Closed
srirambv opened this issue Oct 17, 2018 · 3 comments
Closed

Site banner doesn't auto resize based on browser size #1658

srirambv opened this issue Oct 17, 2018 · 3 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.

Comments

@srirambv
Copy link
Contributor

Description

Site banner doesn't auto resize based on browser size

Steps to Reproduce

  1. Install 0.55.16
  2. Enable rewards and add funds
  3. Visit a site and click on BR button-> Send Tip
  4. Shows banner page, resize browser window, banner doesn't resize and remains in its original size

Actual result:

tip

Expected result:

Banner should auto resize based on browser window size

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.55.16 Chromium: 70.0.3538.54 (Official Build) (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
  • Does it reproduce on browser-laptop?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @petemill @bradleyrichter @jenn-rhim @brave/legacy_qa

@srirambv srirambv added design A design change, especially one which needs input from the design team feature/rewards labels Oct 17, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Oct 17, 2018
@srirambv srirambv mentioned this issue Oct 17, 2018
@LaurenWags
Copy link
Member

Reproduced on macOS

Brave 0.57.1 Chromium: 70.0.3538.67 (Official Build) dev (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Mac OS X

@petemill
Copy link
Member

I knew about this and we took the decision to not have it resize, because in order to get it auto-sizing height according to the content given an initial fixed width of the tab width we lose the ability to change the size. And even when I forced the size change, there were rendering issues. There are ways we could spend some time resolving the issue, but I didn't make the issue to follow-up, so thanks for doing that @srirambv

@kjozwiak
Copy link
Member

Reproduced on Win 10 x64 using the following build:

Brave 0.55.17 Chromium: 70.0.3538.67 (Official Build) (64-bit)
Revision 9ab0cfab84ded083718d3a4ff830726efd38869f-refs/branch-heads/3538@{#1002}
OS Windows

@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Oct 19, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@NejcZdovc NejcZdovc removed the design A design change, especially one which needs input from the design team label Mar 31, 2020
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@kjozwiak kjozwiak added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA/Yes QA/Test-Plan-Specified labels Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated.
Projects
None yet
Development

No branches or pull requests

7 participants