Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farbling remote frames uses incorrect origin #11860

Closed
pilgrim-brave opened this issue Sep 25, 2020 · 4 comments · Fixed by brave/brave-core#6706
Closed

Farbling remote frames uses incorrect origin #11860

pilgrim-brave opened this issue Sep 25, 2020 · 4 comments · Fixed by brave/brave-core#6706
Assignees
@pilgrim-brave
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.16.x - Release #1

Comments

@pilgrim-brave
Copy link

As seen on farbling QA page, remote frames are using their own origin as the farbling key instead of the origin of the containing page.
@pilgrim-brave
Copy link
Author

farbling_remote_1

@pilgrim-brave
Copy link
Author

farbling_remote_2

@pilgrim-brave pilgrim-brave self-assigned this Sep 25, 2020
@pilgrim-brave pilgrim-brave mentioned this issue Sep 25, 2020
Merged
32 tasks
@pilgrim-brave pilgrim-brave added this to the 1.16.x - Beta milestone Sep 30, 2020
@pilgrim-brave pilgrim-brave added QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop release-notes/exclude labels Sep 30, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Oct 5, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (x86_64)
-- | --
Revision | ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified issue description.

Screen Shot 2020-10-05 at 11 35 27 AM

Other issues on these pages were noted with #11839 (comment) and #11368 (comment)

Verification passed on

Brave 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (64-bit)
Revision ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS Ubuntu 18.04 LTS

Verified issue from thedescription.

image

Verification passed on


Brave | 1.16.55 Chromium: 86.0.4240.72 (Official Build) dev (64-bit)
-- | --
Revision | 581582174c512f44f44fd1aea340471f54b2365f-refs/branch-heads/4240@{#1134}
OS | Windows 10 OS Version 1903 (Build 18362.1082)
https://dev-pages.bravesoftware.com/farbling.html https://dev-pages.brave.software/farbling.html
image image

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.16.69 x64 build

https://dev-pages.bravesoftware.com/farbling.html https://dev-pages.brave.software/farbling.html
image image

Verification passed on Samsung Tab A with Android 10 running 1.16.69 x64 build

https://dev-pages.bravesoftware.com/farbling.html https://dev-pages.brave.software/farbling.html
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.16.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fix farbling origin for remote frames brave/brave-core
5 participants
@srirambv @LaurenWags @btlechowski @GeetaSarvadnya @pilgrim-brave